[U-Boot-Users] U-Boot v1.3.2-rc2 released

[Jean-Christophe PLAGNIOL-VILLARD]

On 15:15 Wed 27 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 15:12 Wed 27 Feb     , Michael Schwingen wrote:
> > On Mon, Feb 25, 2008 at 12:02:24AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > actux1:
> > > > 	actux1.c: In function 'checkboard':
> > > > 	actux1.c:92: warning: unused variable 'revision'
> > > Fixed
> > > > -----------------
> > > > actux2:
> > > > 	actux2.c: In function 'checkboard':
> > > > 	actux2.c:100: warning: unused variable 's'
> > > > 	actux2.c:99: warning: unused variable 'revision'
> > > > 	actux2.c: In function 'reset_phy':
> > > > 	actux2.c:130: warning: unused variable 'i'
> > > Fixed
> > > > -----------------
> > > > actux3:
> > > > 	actux3.c: In function 'checkboard':
> > > > 	actux3.c:114: warning: unused variable 'revision'
> > > Fixed
> > 
> > Thanks!
> > 
> > The warning in actux4.c is more interesting: it looks like IXP42x
> > GPIO_INT_ACT_LOW_SET can't handle interrupt lines above GPIO8 at all - these
> > are set in IXP425_GPIO_GPIT2R instead of IXP425_GPIO_GPIT1R. For a quick
> > fix, removing the set for the interrupt line should be OK, since the board
> > does not use PCI in u-boot (yet):
> > 
> > 
> > Signed-off-by: Michael Schwingen <michael at schwingen.org>
> > 
> > diff --git a/board/actux4/actux4.c b/board/actux4/actux4.c
> > index 84037fa..260b6f7 100644
> > --- a/board/actux4/actux4.c
> > +++ b/board/actux4/actux4.c
> > @@ -80,7 +80,6 @@ int board_init (void)
> >         GPIO_INT_ACT_LOW_SET (CFG_GPIO_USBINTB);
> >         GPIO_INT_ACT_LOW_SET (CFG_GPIO_USBINTC);
> >         GPIO_INT_ACT_LOW_SET (CFG_GPIO_RTCINT);
> > -       GPIO_INT_ACT_LOW_SET (CFG_GPIO_PCI_INTA);
> >         GPIO_INT_ACT_LOW_SET (CFG_GPIO_PCI_INTB);
> >  
> >         /* Setup GPIO's for 33MHz clock output */
> > 
> > For the next release, GPIO_INT_ACT_LOW_SET should be fixed, but I don't yet
> > know how exactly - my attempts to switch between IXP425_GPIO_GPIT1R and
> > IXP425_GPIO_GPIT2R in the macro caused warnings in *all* cases.
> > 
> I will prefer that you fix GPIO_INT_ACT_LOW_SET.

I've found I will fix this

Best Regards,
J.