[U-Boot-Users] [PATCH] net/Blackfin: move on-chip MAC driver into drivers/net/
Ben Warren
biggerbadderben at gmail.com
Wed Feb 27 17:14:56 CET 2008
Mike Frysinger wrote:
> On Wednesday 27 February 2008, Haavard Skinnemoen wrote:
>
>> Mike Frysinger <vapier at gentoo.org> wrote:
>>
>>> The Blackfin on-chip MAC driver was being managed in the BF537-STAMP
>>> board directory, but it is not board specific, so relocate it to the
>>> drivers dir so that other Blackfin ports can utilize it.
>>>
>>> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
>>> ---
>>> board/bf537-stamp/Makefile | 2 +-
>>> board/bf537-stamp/ether_bf537.c | 549
>>> --------------------------------------- board/bf537-stamp/ether_bf537.h |
>>> 71 -----
>>> drivers/net/Makefile | 1 +
>>> drivers/net/bfin_mac.c | 523
>>> +++++++++++++++++++++++++++++++++++++ drivers/net/bfin_mac.h |
>>> 89 +++++++
>>> 6 files changed, 614 insertions(+), 621 deletions(-)
>>> delete mode 100644 board/bf537-stamp/ether_bf537.c
>>> delete mode 100644 board/bf537-stamp/ether_bf537.h
>>> create mode 100644 drivers/net/bfin_mac.c
>>> create mode 100644 drivers/net/bfin_mac.h
>>>
>> No objections from me, but I think it would be easier to review such
>> patches if you generated them with git-format-patch -M or something
>> similar.
>>
>
> thanks, i wasnt aware of that flag
>
>
>> That makes the patch show the actual changes to the files
>> without all the rename noise.
>>
>
> in the case of the bfin_mac, the changes are minuscule: fix style in a place
> or two and delete dead code.
> -mike
>
I'm sure you've only done trivial and progressive things, but if it's
not too much trouble, please repost using the -M switch so we're only
seeing real deltas.
thanks,
Ben
More information about the U-Boot
mailing list