[U-Boot-Users] [PATCH] ppc4xx: More cleanup for esd's LCD code

[Stefan Roese]

On Wednesday 02 January 2008, Wolfgang Denk wrote:
> In message <200801021055.17023.matthias.fuchs at esd-electronics.com> you 
wrote:
> > -	} else {
> > +	} else
> >  		/*
> >  		 * Uncompressed BMP image, just use this pointer
> >  		 */
> >  		dst = (uchar *)logo_bmp;
> > -	}
>
> I object against this change. The "else" without curly braces is good
> only if a simple one-liner is following.
>
> Here you have 4 lines, and I definitely want to see braces here.

Right. Please only remove the curly braces if only one line follows. Comments 
and multi-line statements should also be put into the braces.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================