[U-Boot-Users] [PATCH] cfi_flash: Fix bug in flash_isset() to use correct 32bit function

Wolfgang Denk wd at denx.de
Wed Jan 2 16:08:27 CET 2008


In message <1199279186-9871-1-git-send-email-sr at denx.de> you wrote:
> This bug was detected on the LWMON5 target which has 2 Intel 16bit wide
> flash chips connected to a 32bit wide port.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
>  drivers/mtd/cfi_flash.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
> index d1124d3..4f61e36 100644
> --- a/drivers/mtd/cfi_flash.c
> +++ b/drivers/mtd/cfi_flash.c
> @@ -527,7 +527,7 @@ static int flash_isset (flash_info_t * info, flash_sect_t sect,
>  		retval = ((flash_read16(addr) & cword.w) == cword.w);
>  		break;
>  	case FLASH_CFI_32BIT:
> -		retval = ((flash_read16(addr) & cword.l) == cword.l);
> +		retval = ((flash_read32(addr) & cword.l) == cword.l);
>  		break;
>  	case FLASH_CFI_64BIT:
>  		retval = ((flash_read64(addr) & cword.ll) == cword.ll);

Checked in, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am more bored than you could ever possibly be.  Go back to work.




More information about the U-Boot mailing list