[U-Boot-Users] [PATCH 2/2] Remove the obsolete terse version of do_mii()

Jerry Van Baren gerald.vanbaren at ge.com
Fri Jan 4 13:38:06 CET 2008


Shinya Kuribayashi wrote:
> gvb.uboot wrote:
>> Thanks for the patch to clean this up.  While I agree with the patch, 
>> I would appreciate respinning it:
>> * I should be an "Acked by" rather than a signed off by since I didn't 
>> do anything to generate the patch itself.
> 
> As you are the original writer, IMHO you could/should signed-off-by :-)
> But it was my bad to add your sign without asking you. I'll resubmit the
> patch later with your acked-by.

I figure that an acked-by is more appropriate than a signed-off-by 
because, while I approve of the patch, I didn't actually contribute to 
it directly (I contributed the anti-patch, that is, the code that is 
being removed... but that already has my signed-off-by on it).

> Thanks for your kind summary.
> 
>  Shinya

Thanks for rerolling,
gvb




More information about the U-Boot mailing list