[U-Boot-Users] [PATCH] 85xx: Move include of config.h earlier.

Kumar Gala galak at kernel.crashing.org
Tue Jan 8 08:21:07 CET 2008


On Jan 8, 2008, at 12:21 AM, Stefan Roese wrote:

> Hi Kumar,
>
> On Tuesday 08 January 2008, Kumar Gala wrote:
>> Include config.h earlier in the set of #includes so as to avoid an
>> incidental and duplicate definition of CFG_CACHELINE_SIZE.
>
> Why not remove CFG_CACHELINE_SIZE (and the other CFG_CACHE_xxx  
> stuff) from the
> board config files instead? This should be defined correctly in
> asm-ppc/cache.h now.
>
> I made this cleanup for 4xx lately and probably triggered this  
> problem for
> your FSL ports. Sorry about that, but I really think these cache  
> defines
> should be removed from the board config files.

Ok, will send a new patch which drops the cache config from config.h  
for 85xx

- k




More information about the U-Boot mailing list