[U-Boot-Users] [PATCH] Fix Ethernet init() return codes

Ben Warren biggerbadderben at gmail.com
Tue Jan 8 23:07:05 CET 2008


Timur Tabi wrote:
> Ben Warren wrote:
>> Change return values of init() functions in all Ethernet drivers to 
>> conform
>> to the following:
>>
>>> =0: Success
>> <0:  Failure
>>
>> All drivers going forward should return 0 on success.  Current 
>> drivers that
>> return 1 on success were left as-is to minimize changes.
>>
>> Signed-off-by: Ben Warren <biggerbadderben at gmail.com>
>> ---
>>  cpu/ixp/npe/npe.c        |    8 ++++----
>>  cpu/mpc8xx/fec.c         |    6 +++---
>>  drivers/net/dc2114x.c    |    4 ++--
>>  drivers/net/eepro100.c   |    4 ++--
>>  drivers/net/macb.c       |    4 ++--
>>  drivers/net/pcnet.c      |    4 ++--
>>  drivers/net/rtl8139.c    |    4 ++--
>>  drivers/net/rtl8169.c    |    5 +++--
>>  drivers/net/tsec.c       |    2 +-
>>  drivers/net/tsi108_eth.c |    4 ++--
>>  drivers/net/uli526x.c    |    6 +++---
>>  net/eth.c                |    2 +-
>>  12 files changed, 27 insertions(+), 26 deletions(-)
>
> You forgot drivers/qe/uec.c
>
Arrrghhh!  I only looked in cpu and drivers/net
More on the way, I guess...

regards,
Ben




More information about the U-Boot mailing list