[U-Boot-Users] [PATCH V2] Fix Ethernet init() return codes.

Ben Warren biggerbadderben at gmail.com
Wed Jan 9 22:37:36 CET 2008


Wolfgang Denk wrote:
> Dear Ben,
>
> in message <4784FDFE.8030801 at gmail.com> you wrote:
>   
>> Kim Phillips wrote:
>>     
>>> On Wed, 9 Jan 2008 05:58:33 +0100
>>> Stefan Roese <sr at denx.de> wrote:
>>>
>>>   
>>>       
>>>> On Tuesday 08 January 2008, Ben Warren wrote:
>>>>     
>>>>         
>>>>> Change return values of init() functions in all Ethernet drivers to conform
>>>>>
>>>>> to the following:
>>>>> 	>=0: Success
>>>>>
>>>>> 	<0:  Failure
>>>>>
>>>>> All drivers going forward should return 0 on success.  Current drivers that
>>>>> return 1 on success were left as-is to minimize changes.
>>>>>
>>>>> Signed-off-by: Ben Warren <biggerbadderben at gmail.com>
>>>>>       
>>>>>           
>>>> Acked-by: Stefan Roese <sr at denx.de>
>>>>     
>>>>         
>>> for both qe and tsec based devices:
>>>
>>> Acked-by: Kim Phillips <kim.phillips at freescale.com>
>>>
>>> this should be applied asap
>>>
>>> Kim
>>>
>>>   
>>>       
>> Please apply directly.
>>     
>
> Which one? The original "[PATCH V2] Fix Ethernet init() return codes"
> patch?
>
> Best regards,
>
> Wolfgang Denk
>
>   
Yes, the original V2 patch, not the one before it since it missed QE.

regards,
Ben




More information about the U-Boot mailing list