[U-Boot-Users] [PATCH 2/4] TSEC: Add the support for RealTek RTL8211B PHY

[Andy Fleming]

On Jan 11, 2008 4:45 AM, Dave Liu <r63238 at freescale.com> wrote:
> Add the support of RealTek RTL8211B PHY, the RTL8211B
> PHY only supports RGMII and MII mode.
>
> Signed-off-by: Dave Liu <daveliu at freescale.com>
> ---
> +/* Parse the RTL8211B's status register for speed and duplex
> + * information
> + */


I'd prefer if we didn't unnecessarily proliferate phy-specific status
code.  Does the generic mii_parse_sr() function not work for the
RTL8211B?  If so, this is fine.  Otherwise, let's not have 10
different versions of the same code, just because many PHYs have their
own non-standard registers.

Other than that, I'm fine with this, and looking forward to seeing
Ben's PHY rework.  :)

Andy