[U-Boot-Users] [PATCH] Fix "i2c sdram" command for DDR2 DIMMs

gvb.uboot gvb.uboot at gmail.com
Sat Jan 12 18:29:48 CET 2008


Larry Johnson wrote:
> Many of the SPD bytes for DDR2 SDRAM are not interpreted correctly by the
> "i2c sdram" command.  This patch provides correct alternative
> interpretations when DDR2 memory is detected.
> 
> Signed-off-by: Larry Johnson <lrj at acm.org>
> ---
> Hi Wolfgang and Stefan and group,
> 
> In this patch, I have fixed the DDR2 output for the SPD bytes currently
> displayed by the "i2c sdram".  I have not added any display for the
> additional bytes defined in DDR2; I may do that later when I have time.
> 
> I don't have any way of testing the patched code for non-DDR2 memory, but
> if I force the code to treat the DDR2 memory type as "unknown", I get the
> same values as before the patch.
> 
> Stefan, the added size of this causes a section overlap on the Luan board,
> and makes the existing overlap on the Ocotea board worse.
> 
> If memory size is critical, I could redo this patch using conditional
> compilation for different memory types, though I believe this would add
> complexity and reduce flexibility.  If you would prefer this, please let
> me know.
> 
> Best regards,
> Larry

Verified that the code prints the same thing for SDRAM (sacsng board) 
before and after Larry's patches (including "Refactor code for "i2c 
sdram" command") other than some gratuitous ;-) s/nS/ns/ s/uS/us/.

Acked-by: Gerald Van Baren <vanbaren at cideas.com>

Thanks,
gvb





More information about the U-Boot mailing list