[U-Boot-Users] resend [PATCH 2/5]: add AcTux-1 board support

Wolfgang Denk wd at denx.de
Sun Jan 13 16:53:00 CET 2008


In message <20080113125246.GB27114 at discworld.dascon.de> you wrote:
> This patch adds the AcTux-1 specific files.

You are still not consequently indenting by TAB's.

> diff --git a/board/actux1/actux1.c b/board/actux1/actux1.c
> new file mode 100644
> index 0000000..eac85dc
> --- /dev/null
> +++ b/board/actux1/actux1.c
...
> +/*************************************************************************
> + * get_board_rev() - setup to pass kernel board revision information
> + *          0 = reserved
> + *          1 = Rev. A
> + *          2 = Rev. B
-----^^^^^^^^^^
Spaces instead TAB in all these lines.

> diff --git a/board/actux1/u-boot.lds b/board/actux1/u-boot.lds
> new file mode 100644
> index 0000000..e1651f3
> --- /dev/null
> +++ b/board/actux1/u-boot.lds
> +	{
> +	  cpu/ixp/start.o	        (.text)
--------------------------------^^^^^^^^
Spaces, bad alignment.
> +          /* WARNING - the following is hand-optimized to fit within
---^^^^^^^^^^
Spaces.
> +	     the sector before the environment sector. If it throws an
> +	     error during compilation remove an object here to get it
> +	     linked after the configuration sector.  */
> +          lib_generic/string.o          (.text)
---^^^^^^^^^^--------------------^^^^^^^^^^
Spaces.
> +          lib_generic/vsprintf.o        (.text)
---^^^^^^^^^^----------------------^^^^^^^^
Spaces.

etc. etc.

Ditto in the other patches.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Do we define evil as the absence of goodness? It seems only  logical
that shit happens--we discover this by the process of elimination."
                                                        -- Larry Wall




More information about the U-Boot mailing list