[U-Boot-Users] [PATCH 1/2] ppc4xx: Add DU440 board support

[Matthias Fuchs]

I will update the DU440 patch tonight and also update the sequoia
sources in the same manner. So Stefan can lean back :-)

Matthias

On Monday 14 January 2008 10:45, Wolfgang Denk wrote:
> Dear Matthias,
> 
> in message <200801140958.46911.matthias.fuchs at esd-electronics.com> you wrote:
> > 
> > as you might have noticed the DU440 board is havily based on seuqoia code.
> 
> No, I wasn't aware of this.
> 
> > Nearly all of your comments apply to that board as well. I thought of the
> > sequoia code as exemplary reference code. And I prefer not to reformat comments
> > when copy and pasting from one board to another.
> 
> Hm. So I have to talk with the maintainer of this board - especially
> how he managed to run this through the custodian without public
> review. Stefan, how did he bribe you? :-)
> 
> > But if you really insist of these changes I will change the patch.
> 
> Please do. Ideally, please include the Sequoia in your cleanup, too.
> 
> > > > +#if 0
> > > > +/*
> > > > + * test commands for SM722 2D acceleration
> > > > + */
> > > ...
> > > > +U_BOOT_CMD(
> > > > +	gfxline,	CFG_MAXARGS,	1,	do_gfxline,
> > > > +	"gfxline - draw line\n",
> > > > +	"[color] [x1] [y1] [x2] [y2]\n"
> > > > +	);
> > > > +#endif
> > > 
> > > Please remove the dead code.
> > Please not. The DU440 board will get an updated smi_lynxem driver with support for the
> > SM722 soon. My current hack is to dirty for submission and I just got some more register
> > dumps from SM to support more videomodes. I will need this commented out code to test it.
> > I plan to remove it later.
> 
> Please remove it. We use source code management systems to maintain
> test code etc. If it's "#if 0" is has no place in the public code.
> 
> > > You probably may want to adjust the (C) messages in some other files,
> > > too.
> > Ack. May I put my name on it? The source of this code has no copyright either.
> 
> Stefan???
> 
> > > > +  __bss_start = .;
> > > > +  .bss       :
> > > 
> > > NOLOAD attribute missing. Please fix.
> > This is new to me. But I just noticed that all other boards have been updated according to this. So will I.
> 
> Thanks.
> 
> > I will update my patches. Perhaps you can comment on my comments above.
> 
> Done :-)
> 
> Best regards,
> 
> Wolfgang Denk
> 

-- 
-------------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs
SD4

esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Telefon: 0511-37298-0 - Fax: 0511-37298-68
Bitte besuchen Sie uns im Internet unter http://www.esd.eu
Quality Products - Made in Germany
-------------------------------------------------------------------------
Geschäftsführer: Klaus Detering, Dr. Werner Schulze
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------