[U-Boot-Users] [PATCH 1/8] ColdFire: Add MCF547x_8x cpu arch

[Liew Tsi Chung]

Guennadi,

> At least this patch seems line-wrapped to me. Above is just one
example.

Will change to git-send-email, that should take care of it.


>Is this really the correct comment here? I see the code is copied 
>from lib_m68k/time.c. Isn't lib_m68k going to be linked with this 
>board? Won't symbols conflict then? Obviously they don't, as you 
>are running this code, just I don't see immediately how this 
>works. And if CONFIG_SLTTMR is not defined, looks like get_timer 
>will be undefined, right? Is this the intended behaviour?

The MCF547x_8x is a bit different from the rest of the Coldfire, it does
not have dtimer nor pit. The only timer it has are slicetimer and
general purpose timer. There won't be a conflict if any two or any three
of these CONFIG_SLTTMR, CONFIG_MCFTMR or CONFIG_MCFPIT are defined as
the same time.

The only conflict functions are get_tbclk and get_ticks in slicetimer.c.
I will remove them at once.

Regards,
TsiChung