[U-Boot-Users] [PATCH] FSL: Convert board/freescale/common/Makefile to use CONFIG_

[Grant Likely]

On 1/15/08, Kim Phillips <kim.phillips at freescale.com> wrote:
> On Tue, 15 Jan 2008 15:21:09 -0600
> Jon Loeliger <jdl at freescale.com> wrote:
>
> <snip>
> > -COBJS        := sys_eeprom.o \
> > -        pixis.o      \
> > -        pq-mds-pib.o \
> > -        fsl_logo_bmp.o \
> > -        fsl_diu_fb.o
> > +COBJS        := pq-mds-pib.o
> > +
> > +COBJS-${CONFIG_ID_EEPROM}    += sys_eeprom.o
> > +COBJS-${CONFIG_FSL_DIU_FB}   += fsl_diu_fb.o fsl_logo_bmp.o
> > +COBJS-${CONFIG_FSL_PIXIS}    += pixis.o
> > +
> > +COBJS        += ${COBJS-y}

Nit: Don't do it this way; do this instead (to match the style used in
other Makefiles):

+COBJS-y        := pq-mds-pib.o
+COBJS-${CONFIG_ID_EEPROM}    += sys_eeprom.o
+COBJS-${CONFIG_FSL_DIU_FB}   += fsl_diu_fb.o fsl_logo_bmp.o
+COBJS-${CONFIG_FSL_PIXIS}    += pixis.o

-SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
+SRCS   := $(SOBJS:.o=.S) $(COBJS-y:.o=.c)

> >
>
> what, no love for pq-mds-pib.o (CONFIG_PQ_MDS_PIB)?
>
> Kim
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.