[U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files

Kim Phillips kim.phillips at freescale.com
Wed Jan 16 01:43:51 CET 2008


On Tue, 15 Jan 2008 17:09:41 -0600
Timur Tabi <timur at freescale.com> wrote:

> Remove the "#undef DEBUG" line from all Freescale 83xx board header files.
> The inclusion of this line makes it impossible to enable debug code in
> other source files, because "#define DEBUG" typically needs to be defined
> before any header files are included.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
> 
> Added MPC8360ERDK.h.
> 
>  include/configs/MPC8323ERDB.h |    2 --
>  include/configs/MPC832XEMDS.h |    2 --
>  include/configs/MPC8349EMDS.h |    2 --
>  include/configs/MPC8360EMDS.h |    2 --
>  include/configs/MPC8360ERDK.h |    2 --
>  include/configs/MPC837XEMDS.h |    2 --
>  6 files changed, 0 insertions(+), 12 deletions(-)

?  Am I missing something?  mpc83xx files aren't special in this area.
it appears to be a problem for a lot of boards:

include/configs/ads5121.h:#undef DEBUG
include/configs/AP1000.h:#undef DEBUG
include/configs/assabet.h:#undef DEBUG
include/configs/BAB7xx.h:#undef  DEBUG
include/configs/EB+MCF-EV123.h:#undef DEBUG
include/configs/ELPPC.h:#undef  DEBUG
include/configs/ep8248.h:#undef DEBUG
include/configs/ep82xxm.h:#undef DEBUG
include/configs/gcplus.h:#undef	 DEBUG
include/configs/gw8260.h:#undef DEBUG                  /* General debug */
include/configs/IPHASE4539.h:#undef DEBUG				/* General debug */
include/configs/M5235EVB.h:#undef DEBUG
include/configs/M5271EVB.h:#undef DEBUG
include/configs/M5329EVB.h:#undef DEBUG
include/configs/M54455EVB.h:#undef DEBUG
include/configs/mgcoge.h:#undef DEBUG
include/configs/mpc7448hpc2.h:#undef DEBUG
include/configs/MPC8323ERDB.h:#undef DEBUG
include/configs/MPC832XEMDS.h:#undef DEBUG
include/configs/MPC8349EMDS.h:#undef DEBUG
include/configs/MPC8360EMDS.h:#undef DEBUG
include/configs/MPC8360ERDK.h:#undef DEBUG
include/configs/MPC837XEMDS.h:#undef DEBUG
include/configs/MPC8540EVAL.h:#undef DEBUG
include/configs/ms7722se.h:#undef DEBUG
include/configs/ms7750se.h:#undef DEBUG
include/configs/MVBLUE.h:#undef DEBUG
include/configs/ppmc7xx.h:#undef	DEBUG
include/configs/QS823.h:#undef DEBUG				/* debug output code */
include/configs/QS850.h:#undef DEBUG				/* debug output code */
include/configs/QS860T.h:#undef DEBUG				/* debug output code */
include/configs/Rattler.h:#undef DEBUG
include/configs/sacsng.h:#undef DEBUG		      /* General debug */
include/configs/sbc8260.h:#undef DEBUG		      /* General debug */
include/configs/sbc8349.h:#undef DEBUG

Kim




More information about the U-Boot mailing list