[U-Boot-Users] resend #4: [PATCH 4/5]: add AcTux-3 board support

[Jean-Christophe PLAGNIOL-VILLARD]

On 20:12 Tue 15 Jan     , Michael Schwingen wrote:
> 
> Signed-off-by: Michael Schwingen <michael at schwingen.org>
> 
> diff --git a/board/actux3/Makefile b/board/actux3/Makefile
> new file mode 100644
> index 0000000..f6168c3
> --- /dev/null
> +++ b/board/actux3/Makefile
> @@ -0,0 +1,50 @@
> +#
> +int dram_init (void)
> +{
> +	gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
> +	gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
> +
> +	return (0);
> +}
> +
> +void reset_phy (void)
> +{
> +	int i;
> +
> +	/* initialize the PHY */
> +	miiphy_reset ("NPE0", CONFIG_PHY_ADDR);
> +
> +	/* all LED outputs = Link/Act */
> +	miiphy_write ("NPE0", CONFIG_PHY_ADDR, 0x16, 0x0AAA);
> +
> +	/* set all ethernet switch ports to forwarding state */
> +	for (i = 1; i <= 5; i++)
> +		miiphy_write ("NPE0", CONFIG_PHY_ADDR + 8 + i, 0x04, 0x03);
> +
> +}

Could you specify cleary in each baord file on which do you work and
please  be more explicit about his constants, rather than using magic
numbers.

if possible use hexa value.

Best Regards,
J.