[U-Boot-Users] [PATCH] net: reduce boot latency on QE UEC based boards

Joakim Tjernlund joakim.tjernlund at transmode.se
Wed Jan 16 09:48:08 CET 2008


On Tue, 2008-01-15 at 14:11 -0600, Kim Phillips wrote:
> actually polling for PHY autonegotiation to finish enables us to remove the
> 5 second boot prompt latency present on QE based boards.
> 
> call to qe_set_mii_clk_src in init_phy, and mv call to init_phy from
> uec_initialize to uec_init by Joakim Tjernlund; autonegotiation wait
> code shamelessly stolen from tsec driver.
> 
> also rm unused CONFIG_RMII_MODE code.
> 
> Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
> ---
> tested on mpc8360emds, mpc832xemds, and mpc8323erdb.
> 
> Ben, this should probably go through your net tree.
> 
> Joakim, your Acked-by: (or Signed-off-by: even) is welcome here.
> 
> Thank you,
> 
> Kim

Great! 

Tested on my 2 boards with current git. Happy to add my signed off:

Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>


I would like to add this tiny patch on top though:

>From a50cec4bd95e9ec37d0a63e19a6c02c499e76799 Mon Sep 17 00:00:00 2001
From: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
Date: Wed, 16 Jan 2008 09:40:41 +0100
Subject: [PATCH] Remove annoying debug printout for PHY less boards.

PHY less board prints out lots of "read wrong ...":
read wrong value : mii_id 3,mii_reg 2, base e0102320
read wrong value : mii_id 3,mii_reg 3, base e0102320
UEC: PHY is Generic MII (ffffffff)
read wrong value : mii_id 3,mii_reg 4, base e0102320
read wrong value : mii_id 3,mii_reg 0, base e0102320
read wrong value : mii_id 3,mii_reg 1, base e0102320
read wrong value : mii_id 3,mii_reg 1, base e0102320
read wrong value : mii_id 3,mii_reg 5, base e0102320
read wrong value : mii_id 3,mii_reg 1, base e0102320
read wrong value : mii_id 3,mii_reg 1, base e0102320
read wrong value : mii_id 3,mii_reg 5, base e0102320
FSL UEC0: Full Duplex
FSL UEC0: Speed 100BT
FSL UEC0: Link is up
Using FSL UEC0 device

Make this printout depend on UEC_VERBOSE_DEBUG and
remove its definition in uec_phy.c

Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
---
 drivers/qe/uec_phy.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/qe/uec_phy.c b/drivers/qe/uec_phy.c
index f890d4f..c549b6b 100644
--- a/drivers/qe/uec_phy.c
+++ b/drivers/qe/uec_phy.c
@@ -28,7 +28,6 @@
 
 #if defined(CONFIG_QE)
 
-#define UEC_VERBOSE_DEBUG
 #define ugphy_printk(format, arg...)  \
 	printf(format "\n", ## arg)
 
@@ -114,7 +113,7 @@ int uec_read_phy_reg (struct eth_device *dev, int mii_id, int regnum)
 	/* Read MII management status  */
 	value = (u16) in_be32 (&ug_regs->miimstat);
 	if (value == 0xffff)
-		ugphy_warn
+		ugphy_vdbg
 			("read wrong value : mii_id %d,mii_reg %d, base %08x",
 			 mii_id, mii_reg, (u32) & (ug_regs->miimcfg));
 
-- 
1.5.3.8






More information about the U-Boot mailing list