[U-Boot-Users] [PATCH] QE IO: Add initial data to pin configuration + read/write functions

David Saada David.Saada at ecitele.com
Wed Jan 16 10:00:06 CET 2008


> Andy,
> You are generally right. The good practice would be to modify the QE
> initialization tables for all relevant boards. There are 4 such
boards,
> and I can resubmit the patch to include them. Just please note that
this
> value is only relevant for general purpose I/O pins (defined as
output).
> Looking at these 4 boards you can see that all their I/O pins are
defined
> as special functions, so this patch is harmless there. BTW, I tested
the
> patch on two of them (the MPC8568MDS and the MPC8360MDS).
> 
> Regards,
> David.
> 
> > I'm not fundamentally against this patch in principle, but I'm
> > concerned about your statement about boards that don't add the field
> > not needing it.  Wouldn't this open up potential bugs with
> > uninitialized variables being written out to the hardware?
> >
> > Andy

So, would you like me to repost this patch, with the added argument in
all the relevant board tables?
Another thing regarding this: I also have debug commands for
reading/writing parallel I/O pins (pio read/write). I can add it as
cmd_pio under the common folder. Question is whether this is not too
much "Freescale oriented". If not - it can be added to this patch.

David.




More information about the U-Boot mailing list