[U-Boot-Users] [PATCH] FSL: Convert board/freescale/common/Makefile to use CONFIG_

Jon Loeliger jdl at freescale.com
Wed Jan 16 17:45:55 CET 2008


On Tue, 2008-01-15 at 16:59, Grant Likely wrote:

> Nit: Don't do it this way; do this instead (to match the style used in
> other Makefiles):
> 
> -SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> +SRCS   := $(SOBJS:.o=.S) $(COBJS-y:.o=.c)

Double nit-nit: You actually have to cover OBJS
as well as SRCS here. :-)

SRCS	:= $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
OBJS	:= $(addprefix $(obj),$(COBJS-y))

otherwise nothing gets built at all...

[singing]
    O-ho, the swell shiny new patch
    Is a-coming' down the 'net,
    Oh please let be for me!
[nuff]

jdl






More information about the U-Boot mailing list