[U-Boot-Users] [PATCH] TFTP: add host ip addr support

[Wolfgang Denk]

In message <1200517000.31842.70.camel at localhost> you wrote:
> 
> #define MAX_LEN 80
> static char tftp_filename[MAX_LEN];
> 
> strncpy(tftp_filename, str, MAX_LEN);
> tftp_filename[MAX_LEN-1] = 0;
> 
> May be truncated, but never overruns.

Acked-by: wd at denx.de :-)


Except that the length should be 128 to  match  the  boot  file  name
length that BOOTP / DHCP can pass as per RFC.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A committee is a group that keeps the minutes and loses hours.
                                                      -- Milton Berle