[U-Boot-Users] [PATCH v2] QE IO: Add initial data to pin configuration + read/write functions

[David Saada]

> I see that qe_config_iopin() will always write a 0 or 1 now, ignoring the
> current value.  Are you sure this is a good idea?  What if I don't want U-Boot
> to change the current pin value?
Well, not sure how important this is, as this function is typically used for port initialization. This was also the case in the CPM2 initialization tables. Anyway, I can add a value of 2 which would stand for don't care. 

> Plus, doesn't this assume that the pin is set to output?  Shouldn't you check to
> see if the pin is output or input/output, and only write cpdat if it is?  Also,
> I believe that cpdat is used only if the pin is configured as a GPIO.  If so, I
> don't see you check for that, either.
Good points. Will add these checks and repost the patch. Will also try to post in a different mailer to overcome the line wrapping problem.
 
David.