[U-Boot-Users] [PATCH 4/5] [ARM] AT91CAP9 support - board/ files

Stelian Pop stelian at popies.net
Mon Jan 28 11:49:00 CET 2008


Le dimanche 27 janvier 2008 à 01:48 +0100, Wolfgang Denk a écrit :
> In message <1201392141.17917.25.camel at galileo> you wrote:
> > AT91CAP9 support - board/ files
> > 
> > Signed-off-by: Stelian Pop <stelian at popies.net>
> > 
> > ---
> >  board/at91cap9adk/Makefile      |   50 +++++++
> >  board/at91cap9adk/at91cap9adk.c |  275 +++++++++++++++++++++++++++++++++++++++
[...]

> There are coding style issues in this patch;
> indentation not by TAB in board/at91cap9adk/Makefile,

I could not found any coding style issues in this particular file...

> board/at91cap9adk/at91cap9adk.c and probably elsewhere

But yes, there were many coding style problems all over the place. To my
defense, a fair number of them were "imported" when I copied the files
from other places (atmel supplied files or even u-boot tree...). But
this is no excuse to not clean them before submitting new code.

I'm submitting a new version of the patches with hopefuly all coding
style issues resolved.

Stelian.

-- 
Stelian Pop <stelian at popies.net>





More information about the U-Boot mailing list