[U-Boot-Users] [patch] do not use cmd_reset uninitialized in cfi_flash.c
Stefan Roese
sr at denx.de
Tue Jan 29 07:15:59 CET 2008
On Tuesday 29 January 2008, Mike Frysinger wrote:
> The cmd_reset member of the flash info struct is not initialized until the
> specific cmdset function is called. This normally happens by:
> flash_get_size -> flash_detect_cfi -> cmdset_*_init
> That means we cannot use cmd_reset inside of the cfi detection functions.
Right. But your version now uses the Intel reset command (0xff)
unconditionally. AMD/Spansion style flash chips need AMD_CMD_RESET (0xf0)
instead. Any idea how we should handle this?
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
More information about the U-Boot
mailing list