[U-Boot-Users] [PATCH] ARM926: Display Ethernet info in do_bdinfo only if CONFIG_CMD_NET is defined

[Gururaja Hebbar K R]

Hi,

Sorry for the late reply. was out of connection from the e-world for
some time.

At present, in the file u-boot-1.3.1/common/cmd_bdinfo.c, 

(CONFIG_NIOS2) /* Nios-II */
at line 170 
(CONFIG_MICROBLAZE) /* ! PPC, which leaves Microblaze */
at line 197
(CONFIG_M68K) /* M68K */
at line 239

for all these configs we have the ifdef's.

Only for CONFIG_PPC, (CONFIG_NIOS) /* NIOS*/ , MIPS & ARM doesnt have
this ifdefs. hence i added this for ARM Config
Also this option i have added only to ARM section which is at the end. 
At this point in the code, all other configs (NIOS, PPC, MIPS  etc) are
eliminated and only ARM is left out. 
So it doent effect any other systems.

Kindly correct me if i am wrong

Regards
Gururaja
 

-----Original Message-----
From: wd at denx.de [mailto:wd at denx.de] 
Sent: Tuesday, January 08, 2008 11:51 PM
To: Gururaja Hebbar K R
Cc: u-boot-users at lists.sourceforge.net
Subject: Re: [U-Boot-Users] [PATCH] ARM926: Display Ethernet info in
do_bdinfo only if CONFIG_CMD_NET is defined

In message <14408226.post at talk.nabble.com> you wrote:
> 
> This Patch adds if define to bdinfo command to display ethernet 
> information only if CONFIG_CMD_NET is defined for arm modules.

Um... you claim to do this for ARM modules only, but actually yoru code
is a global modification to ALL systems.

And ARM doesn't even have a specific way to pass the MAC address to
Linux.


Your modification makes no sense to me. I tend to reject it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Microsoft Multitasking:
                     several applications can crash at the same time.