[U-Boot-Users] [PATCH][resubmit] AX88180: new gigabit network driver

[Louis]

Dear Ben,

Thanks for your suggestion; I will correct the driver as soon as possible.
And I make a mistake in sending the mail through outlook express, hence making 
indentation problems.

----- Original Message ----- 
From: "Ben Warren" <biggerbadderben at gmail.com>
To: "Ben Warren" <bwarren at qstreams.com>
Cc: "Louis" <louis at asix.com.tw>; <u-boot-users at lists.sourceforge.net>; "[???]"" 
<donald at asix.com.tw>; ""ASIX Donald at sc8-sf-spam2-b.sourceforge.net" 
<=?windows-1252?Q?=22ASIX_Donald?=@sc8-sf-spam2-b.sourceforge.net>
Sent: Wednesday, July 02, 2008 3:49 PM
Subject: Re: [U-Boot-Users] [PATCH][resubmit] AX88180: new gigabit network 
driver


> On Wed, Jul 2, 2008 at 12:07 AM, Ben Warren <bwarren at qstreams.com> wrote:
> <snip>
>
>>> +#define WRITE_TXBUF(data) \
>>> + do { \
>>> +  *(volatile unsigned short *)(AX88180_BASE + TXBUFFER_START) \
>>> +  = data; \
>>> + } while (0)
>>> +
>> In this case, the do{...}while(0) is unnecessary.  Just make the
>> assignment.
>
> Sorry, I was wrong in this case - do{...}while(0) is correct.  Please
> consider replacing all of these macros with static inline functions
> though.  Much easier for everybody that way.
>
> regards,
> Ben
>