[U-Boot-Users] [PATCH] Fix printf errors.

Wolfgang Denk wd at denx.de
Mon Jul 7 00:29:07 CEST 2008


In message <200807021417.m62EHeff016508 at pogo.cesa.opbu.xerox.com> you wrote:
> The compiler will help find mismatches between printf formats and
> arguments if you let it.  This patch adds the necessary attributes to
> declarations in include/common.h, then corrects the resulting compiler
> warnings in several files.  Some of these were bugs, e.g., "$d"
> instead of "%d" and incorrect arguments in common/cmd_fdt.c.  Others
> were just annoying, like int-long mismatches on a system where both
> are 32 bits.  It's worth fixing the annoying errors to catch the real
> ones.
> 
> I can only compile for ppc architecture so have not tested much of the
> source code for further warnings.

Very good. Thanks a lot - but could you please add your signed-off-by
line, and clean up the commit message (move commnets for the posting
that are not intended for the commit message _below_ the "---" line).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Der Irrtum wiederholt sich immerfort in der Tat.  Deshalb muß man das
Wahre unermüdlich in Worten wiederholen.                     - Goethe




More information about the U-Boot mailing list