[U-Boot-Users] [PATCH][RFC] pci: Add check PCI bridge class (Re: [PATCH][RFC] pci: Remove CONFIG_PCI_SKIP_HOST_BRIDGE and Add check PCI class of host bridge)

[Stefan Roese]

Hi Nobuhiro,

sorry about the late reply.

On Tuesday 17 June 2008, Nobuhiro Iwamatsu wrote:
> In current source code, when the device number of PCI is 0, process PCI
> bridge without fail. However, when the device number is 0, it is not PCI
> always bridge. There are times when device of PCI allocates.
>
> This patch add check PCI bridge class.
>
>   - 0x0604 PCI to AGP bridge / PCI to PCI bridge
>   - 0x0605 PCI to PCMCIA bridge
>   - 0x0606 Nu Bus bridge
>   - 0x0607 PCMCIA CardBus controller
>   - 0x0608 RACEWay bridge

I now finally took the time to take a closer look at this issue. Your approach 
doesn't look "clean" to me. To be honsest, the original code isn't "clean" 
either. But with your addition it really get confusing. At least for me.

So let me summarize what the current code (without your patch) does and 
perhaps you could write again what exactly you want to fix/change. And please 
correct me if I am wrong.

Currently, the configuration of the PCI device at BDF == 0,0,0 will be skipped 
if:

a) CONFIG_PCI_CONFIG_HOST_BRIDGE is not defined

or

b) CONFIG_PCI_CONFIG_HOST_BRIDGE is defined but the env variable
   "pciconfighost" is not defined

So this PCI device will get configured if:

c) CONFIG_PCI_CONFIG_HOST_BRIDGE is defined and the env variable
   "pciconfighost" is defined too

If I understand you correctly, then you have some PCI devices at BDF == 0,0,0 
that need to be configured (and not skipped). Correct? If this is correct, 
wouldn't it be enough for you to use "solution" c) from above?

If this is not the case, then please explain again exactly what you need to 
achieve.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================