[U-Boot-Users] [PATCH] Remove duplicate code introduced by commit 597f6c26a18b389903a64692bacbf9a1ca69355b

Peter Tyser ptyser at xes-inc.com
Mon Jul 7 16:48:41 CEST 2008


On Sun, 2008-07-06 at 00:32 +0200, Wolfgang Denk wrote:
> In message <1212092177-1067-1-git-send-email-hugo.villeneuve at lyrtech.com> you wrote:
> > Remove duplicate code introduced by commit
> > 597f6c26a18b389903a64692bacbf9a1ca69355b
> > 
> > Signed-off-by: Hugo Villeneuve <hugo.villeneuve at lyrtech.com>
> > 
> > ---
> > 
> >  common/main.c |    6 ------
> >  1 files changed, 0 insertions(+), 6 deletions(-)
> > 
> > diff --git a/common/main.c b/common/main.c
> > index a17b60b..046da6f 100644
> > --- a/common/main.c
> > +++ b/common/main.c
> > @@ -940,12 +940,6 @@ int readline_into_buffer (const char *const prompt, char * buffer)
> >  	int rc;
> >  	static int initted = 0;
> >  
> > -	if (!initted) {
> > -		hist_init();
> > -		initted = 1;
> > -	}
> > -
> > -
> >  	/*
> >  	 * History uses a global array which is not
> >  	 * writable until after relocation to RAM.
> 
> This doesnt apply to current code. Can you please check and rebase /
> resubmit if this should be still needed?

The same change was picked up in commit 
35ef877f0a8f6232cdef748f442fed5accb2b641 "Additional fix to
readline_into_buffer() with CONFIG_CMDLINE_EDITING before relocating",
so this change should not be needed.

Best,
Peter





More information about the U-Boot mailing list