[U-Boot-Users] [PATCH] pci: Move PCI device configuration check into a separate weak function

Nobuhiro Iwamatsu iwamatsu at nigauri.org
Wed Jul 9 08:30:35 CEST 2008


Hi, Stefan.

2008/7/9 Stefan Roese <sr at denx.de>:
> On Wednesday 09 July 2008, Nobuhiro Iwamatsu wrote:
>> >> When PCI_BDF was 0,0,0, does the board of PPC have the device which
>> >> do not want to initialize?
>> >
>> > This is the current situation, yes. At least on PPC4xx. With this new
>> > patch all platforms can overwrite this default behavior without breaking
>> > backward compatibility.
>>
>> OK, I see.
>>
>> > Does it work for you?
>>
>> Work fine. Thank you.
>
> OK.
>
>> But I have suggestion.
>>
>> If these cords depend on PPC4xx and other PPC platform, I think that move
>> these code to PPC platform.
>> Do you think this suggestion?
>
> I don't know if this current implementation only works for PPC. Its used on
> all platforms using this PCI code right now. So I think we should keep this
> version in this file as default behavior.

OK, I understand.
Acked-By: Nobuhiro Iwamatsu <iwamatsu at nigauri.org>

Are you going to put this patch in 1.3.4?

Best regatds,
 Nobuhiro




More information about the U-Boot mailing list