[U-Boot-Users] [PATCH] fix USB devices with multiple configurations

Markus Klotzbücher mk at denx.de
Thu Jul 10 11:36:41 CEST 2008


Wolfgang Denk <wd at denx.de> writes:

> In message <20080706165805.GG20299 at prithivi.gnumonks.org> you wrote:
>> 
>> This patch fixes bugs in usbdcore*.c related to the use of devices
>> with multiple configurations.
>>     
>> The original code made mistakes about the meaning of configuration value and
>> configuration index, and the resulting off-by-one errors resulted in:
>>     
>> * SET_CONFIGURATION always selected the first configuration, no matter what
>>   wValue is being passed.
>> * GET_DESCRIPTOR/CONFIGURATION always returned the descriptor for the first
>>   configuration (index 0).
>>     
>> Signed-off-by: Harald Welte <laforge at openmoko.org>

Acked-by: Markus Klotzbuecher <mk at denx.de>

> Markus, are you going to add this to the USB repo any time soon?
>
> Or you could just ACK it (if you think so) and tell me to pick up
> directly.

Wolfgang, please apply.

Sorry for the delay.

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de




More information about the U-Boot mailing list