[U-Boot-Users] [PATCH] [PATCH] Fix "usb part" command

Markus Klotzbücher mk at denx.de
Thu Jul 10 12:14:06 CEST 2008


Wolfgang Denk <wd at denx.de> writes:

> In message <121458881184-git-send-email-ceggers at gmx.de> you wrote:
>> From: Christian Eggers <christian at p2400.wgnetz.xx>
>> 
>> Only print partition for selected device if user supplied the <dev> arg with the "usb part [dev]" command.
>
> What is the rationale of this modification, i. e. which bug are you
> fixing?

I think this fix is correct. If I do

usb part

U-Boot (correcly) prints the partitions of all devices. If I type

usb part 0 

i only want the partitions on device 0. Without this patch I still get
all partitions on all devices. This is wrong.

> I think current behaviour is consistent  between  "ide  part",  "scsi
> part",  "usb part" etc. so if there is a problem here this might need
> to be changed elsewhere, too ?

I just took a look at cmd_ide, and AFAICS it does exactly what USB will
do with this patch.

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de




More information about the U-Boot mailing list