[U-Boot-Users] [PATCH] Adds support for the PPC440x5 Processor on Virtex5 FX

[Ricardo Ribalda Delgado]

Hi again

    You are right on all your comments, I am correcting them on my
local copy. Once I receive more comments I will resubmit.

     Thanks and best regards

On Thu, Jul 10, 2008 at 8:36 PM, Wolfgang Denk <wd at denx.de> wrote:
> In message <1215712408-23567-7-git-send-email-ricardo.ribalda at uam.es> you wrote:
>>
>> diff --git a/cpu/ppc4xx/4xx_enet.c b/cpu/ppc4xx/4xx_enet.c
>> index 4e863dc..d55ce56 100644
>> --- a/cpu/ppc4xx/4xx_enet.c
>> +++ b/cpu/ppc4xx/4xx_enet.c
>> @@ -97,7 +97,7 @@
>>   * network support enabled.
>>   * Remark: CONFIG_405 describes Xilinx PPC405 FPGA without EMAC controller!
>>   */
>> -#if defined(CONFIG_CMD_NET) && !defined(CONFIG_405) && !defined(CONFIG_IOP480)
>> +#if defined(CONFIG_CMD_NET) && !defined(CONFIG_405) && !defined(CONFIG_IOP480) && !defined(CONFIG_440_VIRTEX5)
>
> Line too long.
>
>>  #if !(defined(CONFIG_MII) || defined(CONFIG_CMD_MII))
>>  #error "CONFIG_MII has to be defined!"
>> diff --git a/cpu/ppc4xx/4xx_uart.c b/cpu/ppc4xx/4xx_uart.c
>> index a7587d4..e79c48c 100644
>> --- a/cpu/ppc4xx/4xx_uart.c
>> +++ b/cpu/ppc4xx/4xx_uart.c
>> @@ -48,6 +48,7 @@
>>  #include <watchdog.h>
>>  #include <asm/ppc4xx-intvec.h>
>>
>> +#if !defined(CONFIG_440_VIRTEX5)
>>  #ifdef CONFIG_SERIAL_MULTI
>>  #include <serial.h>
>>  #endif
>> @@ -58,6 +59,7 @@
>>
>>  DECLARE_GLOBAL_DATA_PTR;
>>
>> +
>
> Too many empty lines.
>
>>  #if defined(CONFIG_405GP) || defined(CONFIG_405CR) || \
>>      defined(CONFIG_405EP) || defined(CONFIG_405EZ) || \
>>      defined(CONFIG_405EX) || defined(CONFIG_440)
>> @@ -873,3 +875,5 @@ int serial_tstc(void)
>>  #endif /* CONFIG_SERIAL_MULTI */
>>
>>  #endif       /* CONFIG_405GP || CONFIG_405CR */
>> +
>
> Unnecessary empty line.
>
>> +#endif
>> diff --git a/cpu/ppc4xx/cpu.c b/cpu/ppc4xx/cpu.c
>> index 39f439d..defbbba 100644
>> --- a/cpu/ppc4xx/cpu.c
>> +++ b/cpu/ppc4xx/cpu.c
>> @@ -508,6 +508,11 @@ int checkcpu (void)
>>               puts("GT Rev. A");
>>               strcpy(addstr, "Security/Kasumi support");
>>               break;
>> +
>> +     case PVR_VIRTEX5:
>> +             printf(" VIRTEX5");
>> +             break;
>> +
>>
>
> Too many empty lines.
>
>> --- a/cpu/ppc4xx/speed.c
>> +++ b/cpu/ppc4xx/speed.c
>> @@ -415,7 +415,7 @@ ulong get_PCI_freq (void)
>>       return sys_info.freqPCI;
>>  }
>>
>> -#elif !defined(CONFIG_440GX) && !defined(CONFIG_440SP) && !defined(CONFIG_440SPE)
>> +#elif !defined(CONFIG_440GX) && !defined(CONFIG_440SP) && !defined(CONFIG_440SPE) &&!defined(CONFIG_440_VIRTEX5)
>
> Line too long.
>
>> --- a/cpu/ppc4xx/start.S
>> +++ b/cpu/ppc4xx/start.S
>> @@ -367,6 +367,7 @@ skip_debug_init:
>>       /*----------------------------------------------------------------*/
>>       /* Setup interrupt vectors */
>>       /*----------------------------------------------------------------*/
>> +     li      r0,0
>
> Why do you think this was necessary?
>
>> --- a/net/eth.c
>> +++ b/net/eth.c
>> @@ -291,6 +291,7 @@ int eth_initialize(bd_t *bis)
>>       at91sam9_eth_initialize(bis);
>>  #endif
>>
>> +
>
> Too many empoty lines.
>
>>       if (!eth_devices) {
>>               puts ("No ethernet found.\n");
>>               show_boot_progress (-64);
>> @@ -621,7 +622,7 @@ int eth_initialize(bd_t *bis)
>>       at91rm9200_miiphy_initialize(bis);
>>  #endif
>>  #if defined(CONFIG_4xx) && !defined(CONFIG_IOP480) \
>> -     && !defined(CONFIG_AP1000) && !defined(CONFIG_405)
>> +     && !defined(CONFIG_AP1000) && !defined(CONFIG_405) && !defined(CONFIG_440_VIRTEX5)
>
> Line too long.
>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Some people march to the beat of a different drummer. And some people
> tango!
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/