[U-Boot-Users] [PATCH] V3: mpc85xx set CCB:LBC ratio (CONFIG_LBC_CLOCK_RATIO)

Wolfgang Grandegger wg at grandegger.com
Fri Jul 11 11:55:46 CEST 2008


John Ogness wrote:
> I've changed the patch so that it is less intrusive. It now simply
> adds the new function to the "init_sequence" if defined.
> 
> Signed-off-by: John Ogness <john.ogness at linutronix.de>

Could you please send your patches inline next time to simplify 
reviewing? Thanks.

I have a general remark here. Currently, various 85xx boards setup the 
local bus in the board specific code called from checkboard(). Your 
set_lbc_clock_ratio() would be called earlier and is therefore unusable 
for these board. Nevertheless, the setting of the clock rate is just one 
thing to be done to setup the local bus properly but there are more 
including bug fixes. I would appreciate a generic function for that 
purpose to get rid of duplicated code.

Wolfgang.





More information about the U-Boot mailing list