[U-Boot-Users] [PATCH 1/1] hwmon: Cleaning hwmon devices

Michal Simek Monstr at seznam.cz
Fri Jul 11 13:06:43 CEST 2008


> From: Michal Simek <monstr at monstr.eu>
>
> Clean Makefile
> Move device specific values to driver for better reading

>Thanks. One comment below though:
you are welcome


>> -COBJS-y += adm1021.o
>> -COBJS-y += ds1621.o
>> -COBJS-y += ds1722.o
>> -COBJS-y += ds1775.o
>> +COBJS-$(CONFIG_DTT_ADM1021) += adm1021.o
>> +COBJS-$(CONFIG_DTT_DS1621) += ds1621.o
>> +COBJS-$(CONFIG_DS1722) += ds1722.o

>CONFIG_DS1722 does not match the "CONFIG_DTT_foo" idea all other sensors are 
>using. Perhaps you could fix this up too (CONFIG_DS1722 -> CONFIG_DTT_DS1722) 
>with another version of this patch?

Second patch for it seems reasonable for me because there will be change in board config and it will be
better to have full change in one commit. I'll do it and send it.

M





More information about the U-Boot mailing list