[U-Boot-Users] [PATCH 1/1] v2: coding style cleaning for sc520_spunk

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Jul 14 14:16:09 CEST 2008


On 13:52 Mon 14 Jul     , monstr at seznam.cz wrote:
> From: Michal Simek <monstr at monstr.eu>
> 
> there are some long lines in config file
> but this patches clean a lot of coding style issues
> 
> There could be small problem with Daniel name.
> Please check it in merge
> 
> Signed-off-by: Michal Simek <monstr at monstr.eu>
> ---
>  include/configs/sc520_spunk.h |  138 +++++++++++++++++++----------------------
>  1 files changed, 63 insertions(+), 75 deletions(-)
> 
> diff --git a/include/configs/sc520_spunk.h b/include/configs/sc520_spunk.h
> index 051b2e0..179ecdf 100644
> --- a/include/configs/sc520_spunk.h
> +++ b/include/configs/sc520_spunk.h
> @@ -1,6 +1,6 @@
>  /*
>   * (C) Copyright 2002
> - * Daniel Engström, Omicron Ceti AB, daniel at omicron.se.
> + * Daniel Engstr�m, Omicron Ceti AB, daniel at omicron.se.
>   *
>   * See file CREDITS for list of people who contributed to this
>   * project.
> @@ -12,7 +12,7 @@
>   *
>   * This program is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Please do not modify generic licence header
>   * GNU General Public License for more details.
>   *
>   * You should have received a copy of the GNU General Public License
> @@ -33,38 +33,36 @@
>   * (easy to change)
>   */
>  #define CONFIG_BOOTDELAY	15
> -#define CONFIG_BOOTARGS		"root=/dev/mtdblock1 console=ttyS0,9600 " \
> -					"mtdparts=phys:7936k(root),256k(uboot) "
> -#define CONFIG_BOOTCOMMAND	"setenv bootargs root=/dev/nfs ip=autoconf " \
> -					"console=ttyS0,9600 " \
> -					"mtdparts=phys:7808k(root),128k(env),256k(uboot);" \
> -					"bootp;bootm"
> +#define CONFIG_BOOTARGS		"root=/dev/mtdblock1 console=ttyS0,9600 mtdparts=phys:7936k(root),256k(uboot) "
> +#define CONFIG_BOOTCOMMAND	"setenv bootargs root=/dev/nfs ip=autoconf console=ttyS0,9600 mtdparts=phys:7808k(root),128k(env),256k(uboot); bootp; bootm"
too long, please let the previous way
>  
>  #if defined(CONFIG_CMD_KGDB)
>  #define CONFIG_KGDB_BAUDRATE	115200		/* speed to run kgdb serial port */
>  #define CONFIG_KGDB_SER_INDEX	2		/* which serial port to use */
>  #endif

Please be carreful about the 80 characters limits

Best Regards,
J.




More information about the U-Boot mailing list