[U-Boot-Users] [PATCH] Fix some more printf() format problems.

Kumar Gala galak at kernel.crashing.org
Mon Jul 14 17:49:27 CEST 2008


On Jul 14, 2008, at 10:09 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:

> On 09:42 Mon 14 Jul     , Kumar Gala wrote:
>>
>> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
>> ---
>> common/cmd_mp.c  |    2 +-
>> cpu/mpc85xx/mp.c |    4 ++--
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/common/cmd_mp.c b/common/cmd_mp.c
>> index 26a57c5..59d0d15 100644
>> --- a/common/cmd_mp.c
>> +++ b/common/cmd_mp.c
>> @@ -35,7 +35,7 @@ cpu_cmd(cmd_tbl_t *cmdtp, int flag, int argc,  
>> char *argv[])
>>
>> 	cpuid = simple_strtoul(argv[1], NULL, 10);
>> 	if (cpuid >= CONFIG_NR_CPUS) {
>> -		printf ("Core num: %d is out of range[0..%d]\n",
>> +		printf ("Core num: %ld is out of range[0..%d]\n",
> is it not %lu? cpuid is a unsigned long.

probably.

>
>> 				cpuid, CONFIG_NR_CPUS - 1);
>> 		return 1;
>> 	}
>> diff --git a/cpu/mpc85xx/mp.c b/cpu/mpc85xx/mp.c
>> index a527cf3..75ceba9 100644
>> --- a/cpu/mpc85xx/mp.c
>> +++ b/cpu/mpc85xx/mp.c
>> @@ -50,12 +50,12 @@ int cpu_status(int nr)
>>
>> 	if (nr == id) {
>> 		table = (u32 *)get_spin_addr();
>> -		printf("table base @ 0x%08x\n", table);
>> +		printf("table base @ 0x%08x\n", (u32)table);
> why not use %p? it's a pointer.

do we support %p in u-boot?

- k




More information about the U-Boot mailing list