[U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support (new version)

[Jean-Christophe PLAGNIOL-VILLARD]

On 17:26 Mon 14 Jul     , Ricardo Ribalda Delgado wrote:
> -Add support to the ADT7460 Monitor Chip by Analog
> Devices.
> -Correct wrong previous coding style
> -Correct previous use of puts
please add this comment after the ---
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda at uam.es>
> ---
>  drivers/hwmon/Makefile  |    1 +
>  drivers/hwmon/adt7460.c |   86 +++++++++++++++++++++++++++++++++++++++++++++++
>  include/dtt.h           |    3 +-
>  3 files changed, 89 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/hwmon/adt7460.c
> 
> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
> index f09f145..7342b91 100644
> --- a/drivers/hwmon/Makefile
> +++ b/drivers/hwmon/Makefile
> @@ -37,6 +37,7 @@ COBJS-$(CONFIG_DTT_DS1775) += ds1775.o
>  COBJS-$(CONFIG_DTT_LM73) += lm73.o
>  COBJS-$(CONFIG_DTT_LM75) += lm75.o
>  COBJS-$(CONFIG_DTT_LM81) += lm81.o
> +COBJS-$(CONFIG_DTT_ADT7460) += adt7460.o
>  
>  COBJS	:= $(COBJS-y)
>  SRCS	:= $(COBJS:.o=.c)
> diff --git a/drivers/hwmon/adt7460.c b/drivers/hwmon/adt7460.c
> new file mode 100644
> index 0000000..197d86c
> --- /dev/null
> +++ b/drivers/hwmon/adt7460.c
> @@ -0,0 +1,86 @@
> +/*   
     ^^^
please remove whitespace
> +    (C) Copyright 2008
> +    Ricado Ribalda-Universidad Autonoma de Madrid, ricardo.ribalda at uam.es
> +    This work has been supported by: Q-Technology  http://qtec.com/
> +
> +    This program is free software: you can redistribute it and/or modify
> +    it under the terms of the GNU General Public License as published by
> +    the Free Software Foundation, either version 2 of the License, or
> +    (at your option) any later version.
> +
> +    This program is distributed in the hope that it will be useful,
> +    but WITHOUT ANY WARRANTY; without even the implied warranty of
> +    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +    GNU General Public License for more details.
> +
> +    You should have received a copy of the GNU General Public License
> +    along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +*/
please use this style of comment
/*
 * .....
 */
> +
> +#include <common.h>
> +#include <i2c.h>
> +#include <dtt.h>
> +
> +#define ADT7460_ADDRESS 	0x2c
                          ^
> +#define ADT7460_INVALID 	128
                          ^
please remove whitespace
> +#define ADT7460_CONFIG		0x40
> +#define ADT7460_REM1_TEMP	0x25
> +#define ADT7460_LOCAL_TEMP	0x26
> +#define ADT7460_REM2_TEMP	0x27
> +
> +
> +int dtt_get_temp(int sensor)
> +{
> +	int aux;
> +	u8 table[] =
> +	    { ADT7460_REM1_TEMP, ADT7460_LOCAL_TEMP, ADT7460_REM2_TEMP };
> +
> +	if (sensor > 2) {
> +		puts("DTT sensor does not exist\n");
> +		return -1;
> +	}
> +
> +	aux = dtt_read(0, table[sensor]);
> +	if (aux == -1) {
> +		puts("DTT temperature read failed\n");
> +		return -1;
> +
Why no remove this empty line?
> +	}
> +
> +	return aux;
> +}
> diff --git a/include/dtt.h b/include/dtt.h
> index 34053d1..ce0fdfa 100644
> --- a/include/dtt.h
> +++ b/include/dtt.h
> @@ -32,7 +32,8 @@
>      defined(CONFIG_DTT_DS1775) || \
>      defined(CONFIG_DTT_LM81) || \
>      defined(CONFIG_DTT_ADM1021) || \
> -    defined(CONFIG_DTT_LM73)
> +    defined(CONFIG_DTT_LM73) || \
> +    defined(CONFIG_DTT_ADT7460)
Best Regards,
J.