[U-Boot-Users] [PATCH] mpc85xx: make the MxMR register in upmconfig as a parameter

[Andy Fleming]

On Mon, Jul 14, 2008 at 5:54 AM, Sebastian Siewior
<bigeasy at linutronix.de> wrote:
> The default value for the MxMR register is not always the right one.
> This patch adds the value of MxMR register as an additional
> parameter (plus a few defines instead of hex coded values).
>
> Signed-off-by: Sebastian Siewior <bigeasy at linutronix.de>


I'm not convinced this is the right solution.  Anytime we put a
cpu-specific #ifdef for a function definition, we should think long
and hard about why.  Maybe instead of an argument, we should make
mxmr_mode a config value.  Also, unless I'm misreading this patch,
you've broken *every* board with this patch, since there's no change
to any of the invokers of upmconfig to supply the fourth argument.

Could you also explain in greater detail what you are trying to do,
here?  My familiarity with the LBC code is fairly low.

Andy