[U-Boot-Users] [PATCH 3/7] sbc8560: define eth0 and eth1 instead of eth1 and eth2

[Paul Gortmaker]

Andy Fleming wrote:
> On Fri, Jul 11, 2008 at 5:03 PM, Paul Gortmaker
> <paul.gortmaker at windriver.com> wrote:
>   
>> Wolfgang Denk wrote:
>>     
>>>       
>>>> + * MAC addresses directly on it.
>>>> + */
>>>> +#if 0
>>>> +#define CONFIG_ETHADDR              00:01:af:07:9b:8a
>>>> +#define CONFIG_ETH1ADDR             00:01:af:07:9b:8b
>>>>  #define CONFIG_SERVERIP             192.168.0.131
>>>>  #define CONFIG_IPADDR               192.168.0.105
>>>> -#define CONFIG_GATEWAYIP    0.0.0.0
>>>> +#define CONFIG_GATEWAYIP    192.168.0.1
>>>>  #define CONFIG_NETMASK              255.255.255.0
>>>> +#endif
>>>> +
>>>>
>>>>         
>>> I think this should be removed. There is really no good reason to add
>>> network configuration at all to  the  board  config  file  (with  the
>>> exception of the 2 or 3 boards which actually boot from real ROM).
>>>
>>>       
>> No problem.  I'll remove and resend.
>>     
>
> As a compromise between removal and keeping the useful information for
> developers who are doing early bringup on similar boards, I have
> applied this patch, and replaced the above with:
>
> /* You can compile in a MAC address and your custom net settings by using
>  * the following syntax.  Your board should be marked with the assigned
>  * MAC addresses directly on it.
>  *
>  * #define CONFIG_ETHADDR		de:ad:be:ef:00:00
>  * #define CONFIG_ETH1ADDR		fa:ke:ad:dr:es:s!
>   

That seems like a reasonable compromise to me.  Thanks for doing
this and merging the rest of the patches.

Paul.

>  * #define CONFIG_SERVERIP		<server ip>
>  * #define CONFIG_IPADDR		<board ip>
>  * #define CONFIG_GATEWAYIP		<gateway ip>
>  * #define CONFIG_NETMASK		<your netmask>
>  */
>
> Wolfgang, if you still object, I can totally remove it before you pull
> (git rebase --interactive is a wonderful thing).
>
> I also corrected some whitespace issues where comments trailed off the
> end of the line for no good reason.
>
> Thanks,
> Andy
>