[U-Boot-Users] PATCH for U-Boot 1.3.3 DHCP fails withnetgearWGR614v6

Wolfgang Denk wd at denx.de
Tue Jul 15 21:47:58 CEST 2008


In message <f8328f7c0807141542u1a4a0d0m7b5742c59fec17aa at mail.gmail.com> you wrote:
> Wolfgang,
> 
> On Fri, Jul 11, 2008 at 4:05 PM, Robin Getz <rgetz at blackfin.uclinux.org> wrote:
> > On Fri 11 Jul 2008 18:41, Ben Warren pondered:
> >> I'm a bit of an idealist, so I say let's do it right (remove the call to
> >> BootpCopyNetParams()).  Unless somebody with some historical perspective
> >> weighs in, we'll pull it in as soon as the next merge window opens and
> >> see what happens.
> >
> >
> > Fix DHCP protocol so U-Boot does not respond on the network with it's offered
> > IP number until after it has received a DHCP ACK message. Also ensures that
> > U-Boot does it's DHCPREQUEST as broadcast (per RFC 2131).
> >
> >
> > Signed-off-by: Robin Getz <rgetz at blackfin.uclinux.org>
> >
> Acked-by: Ben Warren <biggerbadderben at gmail.com>
> > --- net/bootp.c 2008-07-11 12:05:18.000000000 -0400
> > +++ net/bootp.c 2008-07-11 18:58:15.000000000 -0400
> > @@ -924,8 +924,6 @@
> >                        if (NetReadLong((ulong*)&bp->bp_vend[0]) == htonl(BOOTP_VENDOR_MAGIC))
> >                                DhcpOptionsProcess((u8 *)&bp->bp_vend[4], bp);
> >
> > -                       BootpCopyNetParams(bp); /* Store net params from reply */
> > -
> >                        NetSetTimeout(TIMEOUT * CFG_HZ, BootpTimeout);
> >                        DhcpSendRequestPkt(bp);
> >  #ifdef CFG_BOOTFILE_PREFIX
> >
> 
> I can't pull this in today.  Please apply directly so it gets in RC1

I had to manually apply that and then create a commit that at least
attributes the patch correclty, but the date is wrong - my problem was
that I nver received the original, complete patch by email.

Robin, will you *please* fix your e-mail issues to the list?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The human race has one really effective weapon, and that is laughter.
                                                         - Mark Twain




More information about the U-Boot mailing list