[U-Boot-Users] [PATCH] Remove warnings compiling serial_xuartlite.c

Ricardo Ribalda Delgado ricardo.ribalda at uam.es
Wed Jul 16 16:22:32 CEST 2008


Casting on in_be32 not in MACROS

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda at uam.es>
---
serial_xuartlite.c: In function ‘serial_putc’:
serial_xuartlite.c:59: warning: passing argument 1 of ‘in_be32’ makes pointer from integer without a cast
serial_xuartlite.c:60: warning: passing argument 1 of ‘out_be32’ makes pointer from integer without a cast
serial_xuartlite.c: In function ‘serial_getc’:
serial_xuartlite.c:72: warning: passing argument 1 of ‘in_be32’ makes pointer from integer without a cast
serial_xuartlite.c:73: warning: passing argument 1 of ‘in_be32’ makes pointer from integer without a cast
serial_xuartlite.c: In function ‘serial_tstc’:
serial_xuartlite.c:78: warning: passing argument 1 of ‘in_be32’ makes pointer from integer without a cast

Previous warnings corrected by this patch

 drivers/serial/serial_xuartlite.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c
index 5c41a1c..74546ce 100644
--- a/drivers/serial/serial_xuartlite.c
+++ b/drivers/serial/serial_xuartlite.c
@@ -56,8 +56,8 @@ void serial_putc(const char c)
 {
 	if (c == '\n')
 		serial_putc('\r');
-	while (in_be32(UARTLITE_STATUS) & SR_TX_FIFO_FULL);
-	out_be32(UARTLITE_TX_FIFO, (unsigned char) (c & 0xff));
+	while (in_be32((u32 *) UARTLITE_STATUS) & SR_TX_FIFO_FULL);
+	out_be32((u32 *) UARTLITE_TX_FIFO, (unsigned char) (c & 0xff));
 }
 
 void serial_puts(const char * s)
@@ -69,13 +69,13 @@ void serial_puts(const char * s)
 
 int serial_getc(void)
 {
-	while (!(in_be32(UARTLITE_STATUS) & SR_RX_FIFO_VALID_DATA));
-	return in_be32(UARTLITE_RX_FIFO) & 0xff;
+	while (!(in_be32((u32 *) UARTLITE_STATUS) & SR_RX_FIFO_VALID_DATA));
+	return in_be32((u32 *) UARTLITE_RX_FIFO) & 0xff;
 }
 
 int serial_tstc(void)
 {
-	return (in_be32(UARTLITE_STATUS) & SR_RX_FIFO_VALID_DATA);
+	return (in_be32((u32 *) UARTLITE_STATUS) & SR_RX_FIFO_VALID_DATA);
 }
 
 #endif	/* CONFIG_MICROBLZE */
-- 
1.5.6.2





More information about the U-Boot mailing list