[U-Boot-Users] *** PROBABLY SPAM *** RE: [PATCH] (Resubmit) ADD ARM AMBA PL031 RTCSupport

[Jean-Christophe PLAGNIOL-VILLARD]

> +/* Enable RTC Start in Control register*/
> +void rtc_init(void)
> +{
> +	RTC_WRITE_REG(RTC_CR,RTC_CR_MIE);
please replace by
	RTC_WRITE_REG(RTC_CR, RTC_CR_MIE);
> +	
   ^^^^^
please remove this whitescpace
> +	pl031_initted = 1;
> +}
> +
> +/*
> + * Reset the RTC. We set the date back to 1970-01-01.
> + */
> +void rtc_reset(void)
> +{
> +	RTC_WRITE_REG(RTC_LR,0x00);
please replace by
	RTC_WRITE_REG(RTC_LR, 0x00);
> +	if(!pl031_initted)
> +		rtc_init();
> +}
> +
> +/*
> + * Set the RTC
> +*/
> +void rtc_set(struct rtc_time *tmp)
> +{
> +	unsigned long tim;
> +	
   ^^^^^
please remove this whitescpace
> +	if(!pl031_initted)
> +		rtc_init();
> +
> +	if (tmp == NULL) {
> +		puts("Error setting the date/time\n");
> +		return;
> +	}
> +	
   ^^^^^
please remove this whitescpace
> +	/* Calculate number of seconds this incoming time represents */
> +	tim = mktime(tmp->tm_year, tmp->tm_mon, tmp->tm_mday,
> +	                tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
> +
> +	RTC_WRITE_REG(RTC_LR,tim);
> +}
> +
> +/*
> + * Get the current time from the RTC
> + */
> +int rtc_get(struct rtc_time *tmp)
> +{
> +	ulong tim;
> +	
   ^^^^^
please remove this whitescpace
> +	if(!pl031_initted)
> +		rtc_init();
> +
> +	if (tmp == NULL) {
> +		puts("Error getting the date/time\n");
> +		return -1;
> +	}
> +
> +	tim = RTC_READ_REG(RTC_DR);
> +	
   ^^^^^
please remove this whitescpace
> +	to_tm (tim, tmp);
> +
> +	debug ( "Get DATE: %4d-%02d-%02d (wday=%d)  TIME:
> %2d:%02d:%02d\n",
> +		tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
> +		tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
> +
> +	return 0;
> +}
> +
> +#endif