[U-Boot-Users] [PATCH] fsl-i2c: fix writes to data segment before relocation

Wolfgang Denk wd at denx.de
Mon Jul 21 22:44:03 CEST 2008


In message <20080721201319.GA16567 at game.jcrosoft.org> you wrote:
>
> > +	if (gd->flags & GD_FLG_RELOC)
> Maybe a macro will more clear like
> 	if(is_relacated())

Actually, I disagree here.

Also, for consistency you would have to change many other uses of
(gd->flags & GD_FLG_???) as well.

Let's keep as is.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All easy problems have already been solved.




More information about the U-Boot mailing list