[U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support

Gururaja Hebbar K R gururajakr at sanyo.co.in
Tue Jul 22 03:54:25 CEST 2008


 
Hi j,

>> Could you please send your patch as inline, otherwise it's really
difficult to comment use git-send-email as example
>> and also please read this http://www.denx.de/wiki/UBoot/Patches
>> and http://lwn.net/Articles/139918/

Sorry for the whitespace mistakes. i have now corrected it. 

But regarding sending patch inline i am finding it very difficult. I am
using MS Off Outlook to send patches to uboot and other mailing lists.
I also pasted the same code that i copied from patch files to the mail.
Since i think it wraps and creates other issues, i am attaching the
patch that i generated using " diff -purN ". 

Since our proxy server has some issue, i am not to clone from uboot git
server. So here is the thing.

I have downloaded uboot-1.3.3.tar.bz2 and extracted to local system. I
have copied to the same to a diff directory on which i work.

so,

u-boot-1.3.3/ ---> original unmodified source 
uboot/ ---> modified source

I take a diff of these two folders and send it as patch. Now from past
few days i am trying to use git to create and send patch to mailing
list.

Here is what i do,

1. 1st i tried diff -purN u-boot-1.3.3/drivers/rtc uboot/drivers/rtc/ >
new_pl031_rtc_drvr.patch to create a well known patch creation command

2. then i tried git-diff -p   --summary --stat
u-boot-1.3.3/drivers/rtc/ uboot/drivers/rtc >
new_pl031_rtc_drvr_v2.patch to create another patch.

Both didnt have match difference except the 2nd give me few more info. 
I sent 2 mail to uboot mailing list, each time picking patch from each
step and also pasting from the patch file

3. Now i tried git-format-patch

$ git-format-patch.exe u-boot-1.3.3/drivers/rtc/ uboot/drivers/rtc/
fatal: Not a git repository

So kindly know how to solve this. 

Regards
Gururaja




More information about the U-Boot mailing list