[U-Boot-Users] [Patch 3/3] U-Boot-V2:Board:OMAP Introduce Beagle

Sascha Hauer s.hauer at pengutronix.de
Tue Jul 22 09:42:54 CEST 2008


On Mon, Jul 21, 2008 at 07:19:06PM -0500, Khandenahally, Raghavendra wrote:
> This patch adds support for Beagle Board.
> Beagle board from TI is a development platform
> based on TI's OMAP3530 silicon.
> 
> You can find more about Beagle Board here: www.beagleboard.org
> 
> More on OMAP3530 (including documentation can be found here):
> http://focus.ti.com/docs/prod/folders/print/omap3530.html
> 
> Signed-off-by: Raghavendra KH <r-khandenahally at ti.com>
> 
> ---
>  arch/arm/configs/omap3530_beagle_per_uart_defconfig |  185 +++++++++++++
>  arch/arm/mach-omap/arch-omap.dox                    |    1
>  board/omap/Kconfig                                  |    9
>  board/omap/Makefile                                 |    1
>  board/omap/board-beagle.c                           |  276 ++++++++++++++++++++
>  5 files changed, 472 insertions(+)
> 
> Index: u-boot-v2/board/omap/board-beagle.c
> ===================================================================
> --- /dev/null   1970-01-01 00:00:00.000000000 +0000
> +++ u-boot-v2/board/omap/board-beagle.c 2008-06-24 02:26:07.000000000 +0200
> @@ -0,0 +1,276 @@
> +/**
> + * @file
> + * @brief Beagle Specific Board Initialization routines
> + *
> + * FileName: board/omap/board-beagle.c
> + *
> + * Beagle Board from Texas Instruments as described here:
> + * http://www.beagleboard.org
> + *
> + * This board is based on OMAP3530.
> + * More on OMAP3530 (including documentation can be found here):
> + * http://focus.ti.com/docs/prod/folders/print/omap3530.html
> + *
> + * This file provides initialization in two stages:
> + * @li boot time initialization - do basics required to get SDRAM working.
> + * This is run from SRAM - so no case constructs and global vars can be used.
> + * @li run time initialization - this is for the rest of the initializations
> + * such as flash, uart etc.
> + *
> + * Boot time initialization includes:
> + * @li SDRAM initialization.
> + * @li Pin Muxing relevant for Beagle.
> + *
> + * Run time initialization includes
> + * @li serial @ref serial_ns16550.c driver device definition
> + *
> + * Originally from board/omap/board-sdp343x.c
> + */
> +/*
> + * (C) Copyright 2008
> + * Texas Instruments, <www.ti.com>
> + * Raghavendra KH <r-khandenahally at ti.com>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <console.h>
> +#include <init.h>
> +#include <driver.h>
> +#include <asm/io.h>
> +#include <ns16550.h>
> +#include <asm/arch/silicon.h>
> +#include <asm/arch/sdrc.h>
> +#include <asm/arch/sys_info.h>
> +#include <asm/arch/syslib.h>
> +#include <asm/arch/control.h>
> +#include <asm/arch/omap3-mux.h>
> +#include "board.h"
> +
> +/******************** Board Boot Time *******************/
> +
> +/**
> + * @brief Do the SDRC initialization for 128Meg Micron DDR for CS0
> + *
> + * @return void
> + */
> +static void sdrc_init(void)
> +{
> +       /* SDRAM software reset */
> +       /* No idle ack and RESET enable */
> +       __raw_writel(0x1A, SDRC_REG(SYSCONFIG));
> +       sdelay(100);
> +       /* No idle ack and RESET disable */
> +       __raw_writel(0x18, SDRC_REG(SYSCONFIG));
> +
> +       /* SDRC Sharing register */
> +       /* 32-bit SDRAM on data lane [31:0] - CS0 */
> +       /* pin tri-stated = 1 */
> +       __raw_writel(0x00000100, SDRC_REG(SHARING));
> +
> +       /* ----- SDRC Registers Configuration --------- */
> +       /* SDRC_MCFG0 register */
> +       __raw_writel(0x02584099, SDRC_REG(MCFG_0));
> +
> +       /* SDRC_RFR_CTRL0 register */
> +       __raw_writel(0x54601, SDRC_REG(RFR_CTRL_0));
> +
> +       /* SDRC_ACTIM_CTRLA0 register */
> +       __raw_writel(0xA29DB4C6, SDRC_REG(ACTIM_CTRLA_0));
> +
> +       /* SDRC_ACTIM_CTRLB0 register */
> +       __raw_writel(0x12214, SDRC_REG(ACTIM_CTRLB_0));
> +
> +       /* Disble Power Down of CKE due to 1 CKE on combo part */
> +       __raw_writel(0x00000081, SDRC_REG(POWER));
> +
> +       /* SDRC_MANUAL command register */
> +       /* NOP command */
> +       __raw_writel(0x00000000, SDRC_REG(MANUAL_0));
> +       /* Precharge command */
> +       __raw_writel(0x00000001, SDRC_REG(MANUAL_0));
> +       /* Auto-refresh command */
> +       __raw_writel(0x00000002, SDRC_REG(MANUAL_0));
> +       /* Auto-refresh command */
> +       __raw_writel(0x00000002, SDRC_REG(MANUAL_0));
> +
> +       /* SDRC MR0 register Burst length=4 */
> +       __raw_writel(0x00000032, SDRC_REG(MR_0));
> +
> +       /* SDRC DLLA control register */
> +       __raw_writel(0x0000000A, SDRC_REG(DLLA_CTRL));
> +
> +       return;
> +}
> +
> +/**
> + * @brief Do the pin muxing required for Board operation.
> + * We enable ONLY the pins we require to set. OMAP provides pins which do not
> + * have alternate modes. Such pins done need to be set.

"don't"?

> + *
> + * See @ref MUX_VAL for description of the muxing mode.
> + *
> + * @return void
> + */
> +static void mux_config(void)
> +{
> +
> +       /* SDRC_D0 - SDRC_D31 default mux mode is mode0 */
> +
> +       /* GPMC */
> +       MUX_VAL(CP(GPMC_A1), (IDIS | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_A2), (IDIS | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_A3), (IDIS | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_A4), (IDIS | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_A5), (IDIS | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_A6), (IDIS | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_A7), (IDIS | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_A8), (IDIS | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_A9), (IDIS | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_A10), (IDIS | PTD | DIS | M0));
> +
> +       /* D0-D7 default mux mode is mode0 */
> +       MUX_VAL(CP(GPMC_D8), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_D9), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_D10), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_D11), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_D12), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_D13), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_D14), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_D15), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_CLK), (IDIS | PTD | DIS | M0));
> +       /* GPMC_NADV_ALE default mux mode is mode0 */
> +       /* GPMC_NOE default mux mode is mode0 */
> +       /* GPMC_NWE default mux mode is mode0 */
> +       /* GPMC_NBE0_CLE default mux mode is mode0 */
> +       MUX_VAL(CP(GPMC_NBE0_CLE), (IDIS | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_NBE1), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(GPMC_NWP), (IEN | PTD | DIS | M0));
> +       /* GPMC_WAIT0 default mux mode is mode0 */
> +       MUX_VAL(CP(GPMC_WAIT1), (IEN | PTU | EN | M0));
> +
> +       /* SERIAL INTERFACE */
> +       MUX_VAL(CP(UART3_CTS_RCTX), (IEN | PTD | EN | M0));
> +       MUX_VAL(CP(UART3_RTS_SD), (IDIS | PTD | DIS | M0));
> +       MUX_VAL(CP(UART3_RX_IRRX), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(UART3_TX_IRTX), (IDIS | PTD | DIS | M0));
> +       MUX_VAL(CP(HSUSB0_CLK), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(HSUSB0_STP), (IDIS | PTU | EN | M0));
> +       MUX_VAL(CP(HSUSB0_DIR), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(HSUSB0_NXT), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(HSUSB0_DATA0), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(HSUSB0_DATA1), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(HSUSB0_DATA2), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(HSUSB0_DATA3), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(HSUSB0_DATA4), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(HSUSB0_DATA5), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(HSUSB0_DATA6), (IEN | PTD | DIS | M0));
> +       MUX_VAL(CP(HSUSB0_DATA7), (IEN | PTD | DIS | M0));

This function is unnecessarely big. The two arguments of MUX_VAL could
go together in one 32bit value. This way you could do a loop around an
array of mux values. Of course a struct type could do the same thing,
but having them in one 32bit value allows you to define speaking names
for the pin configs making it easier for future board developers. See
include/asm-arm/arch-imx/imx27-regs.h for an example for what I mean.
This is just an idea, I won't reject the patch because of this.

Sascha
-- 
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9




More information about the U-Boot mailing list