[U-Boot-Users] [PATCH 1/1] Add support for ATMEL AT91SAM9G20EK board

Haavard Skinnemoen haavard.skinnemoen at atmel.com
Thu Jul 24 10:37:03 CEST 2008


"Hong Xu" <hongxu.cn at gmail.com> wrote:
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index aa39284..c3dcce6 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -415,14 +415,14 @@ static int macb_init(struct eth_device *netdev, bd_t *bd)
>  	/* choose RMII or MII mode. This depends on the board */
>  #ifdef CONFIG_RMII
>  #if defined(CONFIG_AT91CAP9) || defined(CONFIG_AT91SAM9260) || \
> -    defined(CONFIG_AT91SAM9263)
> +    defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91SAM9G20)

Hmm...I don't really like the direction this is going. Any chance you
could have all AT91 boards define CONFIG_AT91 and check for that
instead?

Alternatively, we could do it the other way around and test for
CONFIG_AVR32 instead, since all AVR32 boards already define that.

In either case, this should probably be a separate cleanup; I don't
have any objections to your patch.

Haavard




More information about the U-Boot mailing list