[U-Boot-Users] [PATCH] Add support for the hammerhead (AVR32) board

[Haavard Skinnemoen]

Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> wrote:
> On 16:16 Thu 24 Jul     , Haavard Skinnemoen wrote:
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index cbe5c47..bcac300 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -709,6 +709,11 @@ Haavard Skinnemoen <hskinnemoen at atmel.com>
> >  	ATSTK1006	AT32AP7000
> >  	ATNGW100	AT32AP7000
> >  
> > +Alex Raimondi <alex.raimondi at miromico.ch>
> > +Julien May <julien.may at miromico.ch>
> IMHO, it's supposed to have only one board Maintainer

Doesn't hurt with two, does it? Many Linux subsystems have several
maintainers.

> > -#define SM_PM_GCCTRL				0x0060
> > +#define SM_PM_GCCTRL(x)				(0x0060 + 4 * x)
> why do you modify? As I see it's never used.

It is used here:

> +void gclk_init(void)
> +{
> +	/* Hammerhead boards uses GCLK3 as 25MHz output to ethernet PHY */
> +
> +	/* Select GCLK3 peripheral function */
> +	gpio_select_periph_A(GPIO_PIN_PB29, 0);
> +
> +	/* Enable GCLK3 with no input divider, from OSC0 (crystal) */
> +	sm_writel(PM_GCCTRL(3), SM_BIT(CEN));
> +}

Haavard