[U-Boot-Users] [PATCH] Add include for config.h in command.h.

Stefano Babic sbabic at denx.de
Fri Jul 25 08:57:40 CEST 2008


 Because the cmd_tbl_s structure depends on the configuration file,
 it must be assured that config.h is included before the structure is
 evaluated by the compiler. If this is not certain, it could happen
 that the compiler generates structures of different size, depending
 on the fact if the source file includes <config.h> before or after
 <command.h>.
 The effect is that u-boot crashes when tries to relocate the command
 table (for ppc) or try to access to the command table for other
 architectures.
 The problem can happen on board-depending commands.All general
 commands under /common are unaffected, because they include already
 config.h before command.h.

Signed-off-by: Stefano Babic <sbabic at denx.de>
---
 include/command.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/command.h b/include/command.h
index c3ef51d..4a27e97 100644
--- a/include/command.h
+++ b/include/command.h
@@ -27,6 +27,8 @@
 #ifndef __COMMAND_H
 #define __COMMAND_H
 
+#include <config.h>
+
 #ifndef NULL
 #define NULL	0
 #endif
-- 
1.5.4.3





More information about the U-Boot mailing list