[U-Boot-Users] PATCH: Update U-Boot EXT2 Filesystem to support dynamic inode size and optimize ext2 read function to fasten read speed!

[Wolfgang Denk]

In message <007301c8f157$ed683f20$30065e0a at SHZ.ST.COM> you wrote:
> Description:
> The patch updates /fs/ext2/ext2fs.c file. There are two aims:
> 1. Make U-Boot could support the EXT2 dynamic version that ext2_inode_size beyond 128bytes.
>     One new feature be involved: CFG_EXT2_SUPPORT_DYNAMIC_REV
>     Refer to: linux-2.6.24.3 source code.
> 2. Make EXT2 read more fast.
>     One new feature be involved: CFG_OPTIMIZE_EXT2_READ

Do we really need new config options and #ifdeffery for these?

> +++ b/fs/ext2/ext2fs.c
...
> @@ -409,7 +516,7 @@ int ext2fs_read_file
>  			return (-1);
>  		}
>  		blknr = blknr << log2blocksize;
> -
> +		

You're adding trailing white space here. Please don't.

> +#ifdef DEBUG
> +	printf("revision_level = 0x%x, inode_size = 0x%x\n", data->sblock.revision_level, data->sblock.inode_size);
> +#endif

Use debug() instead of #ifdef

And mind the maximum line length.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Certainly there are things in life that money  can't  buy,  but  it's
very funny - Did you ever try buying them without money? - Ogden Nash