[U-Boot-Users] [PATCH] cmd_bdinfo: Fix printf() format warning
Haavard Skinnemoen
haavard.skinnemoen at atmel.com
Wed Jul 30 12:57:55 CEST 2008
Wolfgang Denk <wd at denx.de> wrote:
> > In order to not introduce new warnings on the aforementioned three
> > architectures as well as i386, I added a cast to unsigned long. This
> > should be safe even if bi_baudrate is declared as 'int' (assuming
> > there's no such thing as negative baud rates.)
>
> Instead of the cast, should we not rather fix ARM, BF and MIPS to use
> ulong like anybody else?
Yeah, that's probably better. But I don't know what sort of side
effects that kind of change might cause. There could be code somewhere
that needs bi_baudrate to be signed for some obscure reason.
But if you're ok with it and people are willing to test, I can
certainly make that change.
Haavard
More information about the U-Boot
mailing list